Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Week 2 HW - Henna #20

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Week 2 HW - Henna #20

wants to merge 5 commits into from

Conversation

xhenna92
Copy link

No description provided.

@xhenna92 xhenna92 changed the title Initial pull request Week 2 HW - Henna Jun 23, 2015
}

}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is technically correct, however, it can be optimized into a single loop:

    for (int i = 1; i<25; i++) {
            NSString * decoded2 = [self decode:string2 offset:i];
            if ([string1 isEqualToString:decoded2]) {
                return YES;
            }
    }

    return NO;

The difference is wost case 25 iterations vs. worst case 600+ iterations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants