Remove requirement to specify interface for virtual route in order to track it #2429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a virtual route did not have an interface configured, keepalived would log a warning saying that it could not track the route, and then would disable tracking of that route. It appears that it is not necessary to know the interface in order to track the route, and in any event the netlink message received after adding the route identifies the interface for the route if it is appropriate. So this commit removes the requirement to specify an interface in order to track a route. Signed-off-by: Quentin Armitage <[email protected]>
IPROUTE_ADD was a value in an enum (23) in vrrp_iproute.h, but later in that file IPROUTE_ADD was defined to be 1. This caused IPROUTE_BIT_ADD to have the wrong value. This commit now changes the name in the enum to be IPROUTE_ADD_ROUTE. Signed-off-by: Quentin Armitage <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.