vrrp: Ensure VRRPv3 advert interval is <= 40.95 seconds #2424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 42a746c - "configure: ${prefix} defaults to NONE which messes up DEFAULT_CONFIG_FILE" broke the checking of whether a secondary default config file location is required. This commit resolves the issue. Signed-off-by: Quentin Armitage <[email protected]>
If an advert interval of 40.958 seconds was configured, it was being round up to 40.96 after the check that the advert interval was less than 40.96. The consequence of this was that adverts were being sent at 40.96 second intervals, but worse, the advert interval in the VRRP packet was set to 0. This commit now ensures that after the rounding the advert interval is <= 40.95 seconds. Signed-off-by: Quentin Armitage <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.