Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vrrp: remove logging on status output #2411

Merged
merged 1 commit into from
May 6, 2024

Conversation

feckert
Copy link
Contributor

@feckert feckert commented May 6, 2024

I am the maintainer of the keepalived packages in OpenWrt.
There is also a LuCI frontend that queries the status of keepalived.

To get the status of keepalived, the json signal handling is used.

The problem now is, that when the LuCI status page is open in the browser, this removed message in the PR is show every 3 second on status query. In my opinion, this floods the log and is not necessary.

A message is output to the log each time the status is queried. This is
not necessary and can therefore be omitted.

Signed-off-by: Florian Eckert <[email protected]>
@pqarmitage pqarmitage merged commit ebb1e1f into acassen:master May 6, 2024
10 checks passed
@pqarmitage
Copy link
Collaborator

@feckert Many thanks for you patch. I guess the log message was a hang over from when the JSON functionality developed.

@feckert feckert deleted the pr/20240506-vrrp-status-logging branch May 6, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants