Clone maximized state for the new window/popup

[dmitriy-khokhlov]

Hi,

I have an issue similar to #23 but with "maximized" state of the window (not "full screen" state as it turned out in that issue).

So, when I move a tab from maximized Chrome window to a new window/popup I get this new window/popup in "normal' state (not "maximized"). The extension correctly copies a "normal" size of the original window to new one but it does not copy the "maximized" state. Please add functionality to copy the "maximized" state.

I use Windows 10. Resizing -> Clone setting is set to "On top".

[KnorpelSenf]

@acarabott is it as straightforward as adding

state: 'fullscreen'

to these options if the function argument isFullscreen is true?

I have zero experience with developing Chrome extensions but I'm willing to fix this if there's not too many caveats. I'm not quite sure why the fullscreen property is set afterwards, because state is documented here.

[acarabott]

From what I remember, there were some issues with fullscreen. I did a quick check of changing the state, but it doesn't work as expected.
I might have some time to look at this over the holiday, but can't guarantee. If you want to take a crack at it, you are more than welcome.

[LtDerbs]

Also interested in this. I'll try to play around with it too.

[unicornflax]

I did a redesign of the state handling which fixes this bug. Check my pull request.

[KnorpelSenf]

ref #72

[Technostud]

Is there a version of this extension in the Chrome Web Store that will keep windows in Maximized state? Even if I choose Window, Clone on Top, it does not open the new window in the Maximized state of the original window. Can anyone think of any workarounds to have the windows open in a maximized state?

I see the fork here on Github, but I'm not sure how to update the extension from that. Anyway, I would love a Setting that does something like, "If Current Window Is Maximized, Keep New Window Maximized."

Thanks for such a great extension. Awesome work!!!