Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a feature that shows information about the active window #5

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

asensi
Copy link
Contributor

@asensi asensi commented Mar 18, 2024

Thanks for your attention. There is more detailed information in the comments of the new source code.

@academo
Copy link
Owner

academo commented Jan 17, 2025

Hi @asensi thanks for you PR and apologies for taking so long to take a look at them. things got lost in all my github notifications and I was not paying much attention to this project.

I have made recently many changes to the script and i find harder to implement your changes. specially because the script now incorporates support for kde5 and 6 and might be your script only works with kd5 (not 100% sure)

If you wish to have this in the project, could you please merge main and re-incorporate your changes? it is ok if you only have kde5 or kde6 support but make sure to put it inside an if (see the current ww script to see how detection works)

@asensi
Copy link
Contributor Author

asensi commented Jan 19, 2025

Hi @asensi thanks for you PR and apologies for taking so long to take a look at them. things got lost in all my github notifications and I was not paying much attention to this project.

Better late than never :-)

I have made recently many changes to the script and i find harder to implement your changes. specially because the script now incorporates support for kde5 and 6 and might be your script only works with kd5 (not 100% sure)

The new feature ("show information about the active window") works (at least) using Kubuntu 24.10 with KDE Plasma 6, under Wayland and X11. If anyone tries to use that new feature with Plasma 5, an error message is seen.

If you wish to have this in the project, could you please merge main and re-incorporate your changes? it is ok if you only have kde5 or kde6 support but make sure to put it inside an if (see the current ww script to see how detection works)

In that case, the if is that one: if [[ "$kwinMajorVersion" -lt "$minimumVersion" ]]; then.

If you wish to have this in the project, could you please merge main and re-incorporate your changes?

I've resolved the git conflicts using the Github interface, after that I've pressed the button that Github showed (although that action has created another commit, you can "squash" the commits while you merge).

@academo academo merged commit 0a06356 into academo:master Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants