fix: ESM compatibility - avoid direct Response object mutation

[omarmciver]

Summary

Fixes #1429 - Response object mutation fails in ESM environments

Problem

The Fetch client template directly mutates Response objects by adding data and error properties. This works in CommonJS but fails in ESM with node-fetch v3 where Response objects are truly read-only.

Solution

Instead of mutating the Response object, this PR creates a wrapper object that:

• Contains the custom data and error properties
• Delegates all Response properties and methods to the original response
• Maintains full backward compatibility with existing code
• Works in both CommonJS and ESM environments

Changes

Modified templates/base/http-clients/fetch-http-client.ejs to create a wrapper object instead of directly mutating the Response:

// Before (fails in ESM):
const r = response as HttpResponse<T, E>;
r.data = null;
r.error = null;

// After (works everywhere):
const r = {
  data: null,
  error: null,
  // Delegate Response properties
  ok: response.ok,
  status: response.status,
  // ... etc
  // Delegate Response methods
  json: () => response.json(),
  text: () => response.text(),
  // ... etc
} as HttpResponse<T, E>;

Testing

• ✅ Created test script to verify the template generates correct code
• ✅ Tested that the fix doesn't directly mutate Response objects
• ✅ Verified wrapper object is created properly
• ✅ Confirmed backward compatibility is maintained

Breaking Changes

None - this change is fully backward compatible. The generated API clients will have the same interface and behavior, but will now work in ESM environments.

Additional Notes

This fix enables users to migrate to:

• ESM modules ("type": "module" in package.json)
• node-fetch v3 (ESM-only version)
• Native fetch in Node.js 18+

Without this fix, users need workarounds like wrapping fetch with a Proxy to make Response properties writable, which is not ideal.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 837a381

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[smorimoto]

bugbot run

[smorimoto]

@codex review

[smorimoto]

@omarmciver Could you add a changeset?

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

• @codex fix this CI failure
• @codex address that feedback

[cursor]

This PR is being reviewed by Cursor Bugbot

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

[Copilot]

Pull Request Overview

This PR fixes ESM compatibility issues by replacing direct mutation of Response objects with a Proxy-based wrapper approach. The change addresses failures in ESM environments where Response objects are read-only, while maintaining full backward compatibility.

• Replaces direct Response object mutation with a Proxy wrapper
• Uses internal _data and _error properties to store custom values
• Delegates all Response properties and methods to the original object

Reviewed Changes

Copilot reviewed 29 out of 29 changed files in this pull request and generated 2 comments.

File	Description
templates/base/http-clients/fetch-http-client.ejs	Modified HTTP client template to use Proxy instead of direct mutation
tests/**/snapshots/*.snap	Updated test snapshots to reflect the new Proxy-based implementation

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

[nitpick] The ternary operator with type assertions is hard to read. Consider simplifying to return target._data ?? (null as unknown as T); for better clarity.

Suggested change

	return target._data !== undefined ? target._data : (null as unknown) as T;
	return target._data ?? (null as unknown as T);

[Copilot]

[nitpick] The setter silently fails for non-data/error properties. Consider adding a comment explaining that this prevents accidental mutation of Response properties, or throwing an error to make the failure explicit.

Suggested change

	return false;
	throw new Error(
	`Cannot set property '${String(prop)}' on HttpResponse: only 'data' and 'error' can be set.`
	);