highforce material adjustments #570
Conversation
old values for reference: [SHADER_REPLACEMENT_...] ACTIVE = 1 MATERIALS = grassBaked, terrain PROP_... = ksAmbient, 0.2 PROP_... = ksDiffuse, 0.2 [SHADER_REPLACEMENT_...] ACTIVE = 1 MATERIALS = grassClip, grass PROP_... = ksAmbient, 0.25 PROP_... = ksDiffuse, 0.25 [SHADER_REPLACEMENT_...] ACTIVE = 1 MATERIALS = walls PROP_... = ksAmbient, 0.25 PROP_... = ksDiffuse, 0.25 [SHADER_REPLACEMENT_...] ACTIVE = 1 MATERIALS = Trees PROP_... = ksAmbient, 0.2 PROP_... = ksDiffuse, 0.2 [SHADER_REPLACEMENT_...] ACTIVE = 1 MATERIALS = conifers PROP_... = ksAmbient, 0.25 PROP_... = ksDiffuse, 0.25 [SHADER_REPLACEMENT_...] ACTIVE = 1 MATERIALS = flowersA PROP_... = ksAmbient, 0.2 PROP_... = ksDiffuse, 0.2
|
wanted to add @BrunUK as reviewer but not sure how |
|
Changes do look good, although I'm wondering how they look at dawn/sunset as ksAmbient is higher than ksDiffuse (personally I much prefer the opposite) In my experience, ksAmbient tends to glow too much in those scenarios and it'll pop up more with other surroundings, so I prefer reducing brightness by lowering ksAmbient rather than ksDiffuse |
avoid higher ksambient than ksdiffuse except for grass, where lowering ksambient is causing grassfx to increase in brightness and look weird.
|
yes makes sense, however lowering ksambient has basically no effect on the trees on this track for some reason. i've made another commit to at least make ksambient equal to ksdiffuse for everything apart from the grass tweak, as for some reason decreasing ksambient is causing grassfx to get much brighter and look weird. also didnt mess with the walls as they look balanced to me heres a screenshot with/without my commits (with purelinear as pure filter seems to underexpose and crush blacks at dusk/dawn)
example of aforementioned grassfx issue if set ksambient to 0.16 to match ksdiffuse i also noticed that seasonal adjustments is working odd, and trees start to change to autumn as the sun goes down in summer, not sure if therse an easy fix. theres an ext config in the track as well as this one in the github maybe with some conflict |
|
Brun wanted to review the changes before them being committed (but isn't using AC1 atm so may not happen), so maybe best to revert |
grass, trees, flowers, walls. tried to be as reserved as possible with the adjustments as there are many variables at play.
pure lcs (1) after
pure lcs (1) before
pure lcs (2) after
pure lcs (2) before
pure lcs (3) after
pure lcs (3) before
default wfx (1) after
default wfx (1) before
default wfx (2) after
default wfx (2) before
old values for reference:
[SHADER_REPLACEMENT_...]
ACTIVE = 1
MATERIALS = grassBaked, terrain
PROP_... = ksAmbient, 0.2
PROP_... = ksDiffuse, 0.2
[SHADER_REPLACEMENT_...]
ACTIVE = 1
MATERIALS = grassClip, grass
PROP_... = ksAmbient, 0.25
PROP_... = ksDiffuse, 0.25
[SHADER_REPLACEMENT_...]
ACTIVE = 1
MATERIALS = walls
PROP_... = ksAmbient, 0.25
PROP_... = ksDiffuse, 0.25
[SHADER_REPLACEMENT_...]
ACTIVE = 1
MATERIALS = Trees
PROP_... = ksAmbient, 0.2
PROP_... = ksDiffuse, 0.2
[SHADER_REPLACEMENT_...]
ACTIVE = 1
MATERIALS = conifers
PROP_... = ksAmbient, 0.25
PROP_... = ksDiffuse, 0.25
[SHADER_REPLACEMENT_...]
ACTIVE = 1
MATERIALS = flowersA
PROP_... = ksAmbient, 0.2
PROP_... = ksDiffuse, 0.2