Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: adding array broadcast to non scalar outputs #63

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

gregstarr
Copy link
Contributor

@gregstarr gregstarr commented Feb 26, 2021

This is a rough draft of the feature described in #62 , created this to illustrate the proposed changes

@gregstarr gregstarr marked this pull request as draft February 26, 2021 01:05
@gregstarr gregstarr mentioned this pull request Feb 26, 2021
8 tasks
@coveralls
Copy link

coveralls commented Feb 26, 2021

Pull Request Test Coverage Report for Build 653

  • 21 of 21 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.8%) to 97.647%

Totals Coverage Status
Change from base Build 632: 0.8%
Covered Lines: 389
Relevant Lines: 397

💛 - Coveralls

@aburrell
Copy link
Owner

Hi @gregstarr, the codebase is in good enough shape to move forward with this now. Adding unit tests and an example in the docs are probably the next steps. Not any rush, but let me know if you aren't interested in doing this yourself.

@gregstarr
Copy link
Contributor Author

Okay thanks for letting me know. I'd be happy to do it.

@gregstarr
Copy link
Contributor Author

Hello, I have not forgotten about this, I am in the midst of finishing my masters thesis and so will have time in about a month.

@aburrell aburrell added this to the Future milestone Nov 1, 2022
@aburrell
Copy link
Owner

Resolved the merge conflicts in the branch: https://github.com/aburrell/apexpy/tree/enh-broadcast-arrays

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants