Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction PR #123. #127

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Correction PR #123. #127

merged 2 commits into from
Nov 7, 2024

Conversation

ljlamarche
Copy link
Collaborator

Description

This is a correction to PR #123 which was merged without incorporating the suggested revisions. These revisions (which were all non-function-impacting style corrections) have now been made and are included in this PR. No other changes have been made.

Checklist

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to Changelog.rst, summarising the changes
  • Add yourself to AUTHORS.rst and .zenodo.json

@ljlamarche ljlamarche mentioned this pull request Sep 30, 2023
11 tasks
@aburrell aburrell marked this pull request as ready for review November 7, 2024 14:57
@aburrell aburrell merged commit a257b0b into aburrell:develop Nov 7, 2024
10 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants