Skip to content
This repository was archived by the owner on Jul 6, 2025. It is now read-only.

Add strict permissions flag#800

Open
MisterTea wants to merge 2 commits intoabumq:masterfrom
MisterTea:add_strict_permissions_flag
Open

Add strict permissions flag#800
MisterTea wants to merge 2 commits intoabumq:masterfrom
MisterTea:add_strict_permissions_flag

Conversation

@MisterTea
Copy link
Copy Markdown

@MisterTea MisterTea commented Nov 2, 2021

Hey all! Thanks for creating a beautiful and simple logging library.

We use easyloggingpp in Eternal Terminal ( https://github.com/MisterTea/EternalTerminal ) and would like the logs to only be readable by the user and group that created them (especially for logs created by root). This PR adds a compile flag for that.

A couple of points:

  1. I'm not sure if a compile flag is the right approach, but it looked like creating an option would require us to pass the option all the way down to file creation, which could be a much bigger change.
  2. If the flag is on, I try to bring in std::filesystem to ensure that the correct permissions are set on unix and windows. If this is too large of a footprint, we could do it only for unix.

This is a

  • Breaking change
  • New feature
  • Bugfix

I have

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant