Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing return value for Command's execute() methods (Symfony >= 4.4) #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sebb
Copy link

@sebb sebb commented Jan 23, 2021

Fixes:

Return value of "Ambta\DoctrineEncryptBundle\Command\DoctrineEncryptStatusCommand::execute()" must be of the type int, "null" returned.
when using Symfony 5

Similar to #41 with the reviewers' suggestions implemented.

Return value of "Ambta\DoctrineEncryptBundle\Command\DoctrineEncryptStatusCommand::execute()" must be of the type int, "null" returned.
@tikoflano
Copy link

It would probably be better not to use self::FAILURE and self::SUCCESS but rather 1 and 0 in order to still support versions of Symonfy < 5.1

@r3hp1c
Copy link

r3hp1c commented Jul 17, 2023

Similar to another pull request that that were copied: DoctrineEncryptBundle#4

Please see these comments:

The new package that I hope will be maintained by more than 1 person

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants