Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Add exclude to relations #84

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jeandelacruz
Copy link

@jeandelacruz jeandelacruz commented May 3, 2022

- I was able to observe that the option to exclude fields from serialization does not work, when they are relations

@michaelbukachi
Copy link
Collaborator

@jeandelacruz Where's the issue associated with this PR?

@jeandelacruz
Copy link
Author

@jeandelacruz Where's the issue associated with this PR?

It really was the need, as I was testing in a case where I have 2 related models and I wanted to exclude one of them, it couldn't be done, and that's where I saw the solution

@michaelbukachi
Copy link
Collaborator

@jeandelacruz Where's the issue associated with this PR?

It really was the need, as I was testing in a case where I have 2 related models and I wanted to exclude one of them, it couldn't be done, and that's where I saw the solution

I understand. However, we should always strive to create issues first before creating PRs in case further discussion is required.

@jeandelacruz
Copy link
Author

@jeandelacruz Where's the issue associated with this PR?

It really was the need, as I was testing in a case where I have 2 related models and I wanted to exclude one of them, it couldn't be done, and that's where I saw the solution

I understand. However, we should always strive to create issues first before creating PRs in case further discussion is required.

Thank you very much, I just added the issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants