Fix ambiguous FormatConvertImpl when type has both AbslStringify and AbslFormatConvert#2024
Open
dr-feld wants to merge 1 commit intoabseil:masterfrom
Open
Fix ambiguous FormatConvertImpl when type has both AbslStringify and AbslFormatConvert#2024dr-feld wants to merge 1 commit intoabseil:masterfrom
dr-feld wants to merge 1 commit intoabseil:masterfrom
Conversation
…AbslFormatConvert When a type defines both AbslStringify and AbslFormatConvert, FormatConvertImpl overload resolution was ambiguous, causing a compilation error. Fix by giving AbslStringify priority over AbslFormatConvert when both are defined, consistent with the intended use of AbslStringify as the preferred extension mechanism. Fixes abseil#1966
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a type defines both
AbslStringifyandAbslFormatConvert, callingabsl::StrFormat("%v", value)caused a compilation error due to ambiguous overload resolution inFormatConvertImpl.This fix gives
AbslStringifypriority overAbslFormatConvertwhen both are defined, by:!HasAbslStringify<T>::valueguard to theAbslFormatConvertoverload ofFormatConvertImplArgumentToConv()to returnvconversion char set when both methods are presentA test is added to verify that
AbslStringifyis called when both methods are defined.Fixes #1966