Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add files upload to rooms #46

Merged
merged 8 commits into from
Aug 22, 2023
Merged

Add files upload to rooms #46

merged 8 commits into from
Aug 22, 2023

Conversation

MrRTi
Copy link
Contributor

@MrRTi MrRTi commented Jul 7, 2023

This PR adds ability to upload files using rooms.upload endpoint

abrom
abrom requested changes Aug 6, 2023
View reviewed changes
Copy link
Owner

@abrom abrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good @MrRTi 👍

One minor thing, otherwise good to go

.rubocop.yml Outdated Show resolved Hide resolved
@MrRTi MrRTi requested a review from abrom August 11, 2023 07:17
abrom
abrom approved these changes Aug 22, 2023
View reviewed changes
Copy link
Owner

@abrom abrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @MrRTi 👍

@abrom abrom merged commit bac8079 into abrom:main Aug 22, 2023
5 checks passed
@abrom
Copy link
Owner

abrom commented Aug 22, 2023

Released in v0.2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abrom abrom abrom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MrRTi @abrom