Bump version to 0.1.19

Address CVE-2020-8130 - `rake` OS command injection vulnerability Fix some Rubocop warnings
abrom · Mar 1, 2020 · 13f430b · 13f430b
1 parent 4664693
commit 13f430b
Show file tree

Hide file tree

Showing 41 changed files with 91 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,10 @@
 ## Unreleased
 - None
 
+## [0.1.19](releases/tag/v0.1.19) - 2019-03-01
+### Fixed
+- Address CVE-2020-8130 - `rake` OS command injection vulnerability
+
 ## [0.1.18](releases/tag/v0.1.18) - 2018-01-05
 ### Added
 - [#29] Support for im.create and im.counters ([@christianmoretti][])

diff --git a/Gemfile b/Gemfile
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 # Specify your gem's dependencies in rocketchat.gemspec

diff --git a/Rakefile b/Rakefile
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
 

diff --git a/bin/console b/bin/console
@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'bundler/setup'
 require 'rocketchat'

diff --git a/lib/rocket_chat/error.rb b/lib/rocket_chat/error.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RocketChat
   class Error < StandardError; end
   class HTTPError < Error; end

diff --git a/lib/rocket_chat/gem_version.rb b/lib/rocket_chat/gem_version.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RocketChat
-  VERSION = '0.1.18'.freeze
+  VERSION = '0.1.19'
 end
diff --git a/lib/rocket_chat/im_summary.rb b/lib/rocket_chat/im_summary.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RocketChat
   #
   # Rocket.Chat IM Summary

diff --git a/lib/rocket_chat/info.rb b/lib/rocket_chat/info.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RocketChat
   #
   # Rocket.Chat Info

diff --git a/lib/rocket_chat/message.rb b/lib/rocket_chat/message.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RocketChat
   #
   # Rocket.Chat Message

diff --git a/lib/rocket_chat/messages/channel.rb b/lib/rocket_chat/messages/channel.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RocketChat
   module Messages
     #

diff --git a/lib/rocket_chat/messages/chat.rb b/lib/rocket_chat/messages/chat.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RocketChat
   module Messages
     #

diff --git a/lib/rocket_chat/messages/group.rb b/lib/rocket_chat/messages/group.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RocketChat
   module Messages
     #

diff --git a/lib/rocket_chat/messages/im.rb b/lib/rocket_chat/messages/im.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RocketChat
   module Messages
     #

diff --git a/lib/rocket_chat/messages/list_support.rb b/lib/rocket_chat/messages/list_support.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RocketChat
   module Messages
     #

diff --git a/lib/rocket_chat/messages/room.rb b/lib/rocket_chat/messages/room.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RocketChat
   module Messages
     #

diff --git a/lib/rocket_chat/messages/room_support.rb b/lib/rocket_chat/messages/room_support.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RocketChat
   module Messages
     #

diff --git a/lib/rocket_chat/messages/settings.rb b/lib/rocket_chat/messages/settings.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RocketChat
   module Messages
     #

diff --git a/lib/rocket_chat/messages/user.rb b/lib/rocket_chat/messages/user.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RocketChat
   module Messages
     #

diff --git a/lib/rocket_chat/messages/user_support.rb b/lib/rocket_chat/messages/user_support.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RocketChat
   module Messages
     #

diff --git a/lib/rocket_chat/presence_status.rb b/lib/rocket_chat/presence_status.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RocketChat
   #
   # Rocket.Chat PresenceStatus

diff --git a/lib/rocket_chat/request_helper.rb b/lib/rocket_chat/request_helper.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'uri'
 require 'openssl'
 require 'net/http'
@@ -30,7 +32,7 @@ def request_json(path, options = {})
       check_response response, fail_unless_ok
 
       response_json = parse_response(response.body)
-      options[:debug].puts("Response: #{response_json.inspect}") if options[:debug]
+      options[:debug]&.puts("Response: #{response_json.inspect}")
       check_response_json response_json, upstreamed_errors
 
       response_json

diff --git a/lib/rocket_chat/room.rb b/lib/rocket_chat/room.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RocketChat
   #
   # Rocket.Chat Room

diff --git a/lib/rocket_chat/server.rb b/lib/rocket_chat/server.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RocketChat
   #
   # Rocket.Chat Server

diff --git a/lib/rocket_chat/session.rb b/lib/rocket_chat/session.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RocketChat
   #
   # Rocket.Chat Session

diff --git a/lib/rocket_chat/token.rb b/lib/rocket_chat/token.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RocketChat
   #
   # Rocket.Chat Token

diff --git a/lib/rocket_chat/user.rb b/lib/rocket_chat/user.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RocketChat
   #
   # Rocket.Chat User

diff --git a/lib/rocket_chat/util.rb b/lib/rocket_chat/util.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RocketChat
   #
   # Rocket.Chat generic utility functions

diff --git a/lib/rocketchat.rb b/lib/rocketchat.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rocket_chat/gem_version'
 
 require 'json'

diff --git a/rocketchat.gemspec b/rocketchat.gemspec
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
@@ -19,7 +21,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
 
   spec.add_development_dependency 'bundler', ['>= 1.11', '< 3.0']
-  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'rake', '>= 12.3.3'
   spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'rubocop', '~> 0.62'
   spec.add_development_dependency 'rubocop-rspec', '~> 1.31'

diff --git a/spec/rocket_chat/message_spec.rb b/spec/rocket_chat/message_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe RocketChat::Message do

diff --git a/spec/rocket_chat/messages/channel_spec.rb b/spec/rocket_chat/messages/channel_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe RocketChat::Messages::Channel do

diff --git a/spec/rocket_chat/messages/chat_spec.rb b/spec/rocket_chat/messages/chat_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe RocketChat::Messages::Chat do

diff --git a/spec/rocket_chat/messages/group_spec.rb b/spec/rocket_chat/messages/group_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe RocketChat::Messages::Group do

diff --git a/spec/rocket_chat/messages/im_spec.rb b/spec/rocket_chat/messages/im_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe RocketChat::Messages::Im do

diff --git a/spec/rocket_chat/messages/settings_spec.rb b/spec/rocket_chat/messages/settings_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe RocketChat::Messages::Settings do

diff --git a/spec/rocket_chat/messages/user_spec.rb b/spec/rocket_chat/messages/user_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe RocketChat::Messages::User do

diff --git a/spec/rocket_chat/server_spec.rb b/spec/rocket_chat/server_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe RocketChat::Server do

diff --git a/spec/rocket_chat/session_spec.rb b/spec/rocket_chat/session_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe RocketChat::Session do

diff --git a/spec/rocket_chat/user_spec.rb b/spec/rocket_chat/user_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe RocketChat::User do

diff --git a/spec/shared/room_behaviors.rb b/spec/shared/room_behaviors.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 shared_examples 'room_behavior' do |room_type: nil, query: false|
   let(:server) { RocketChat::Server.new(SERVER_URI) }
   let(:token) { RocketChat::Token.new(authToken: AUTH_TOKEN, userId: USER_ID) }

diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'simplecov'
 SimpleCov.start
 
@@ -10,11 +12,11 @@
 require 'shared/room_behaviors'
 
 SERVER_URI = URI.parse('http://www.example.com/')
-AUTH_TOKEN = 'AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA'.freeze
-USER_ID = 'AAAAAAAAAAAAAAAAA'.freeze
-OTHER_USER_ID = 'BBBBBBBBBBBBBBBBB'.freeze
-USERNAME = 'user'.freeze
-PASSWORD = 'password'.freeze
+AUTH_TOKEN = 'AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA'
+USER_ID = 'AAAAAAAAAAAAAAAAA'
+OTHER_USER_ID = 'BBBBBBBBBBBBBBBBB'
+USERNAME = 'user'
+PASSWORD = 'password'
 UNAUTHORIZED_BODY = {
   status: :error,
   message: 'You must be logged in to do this.'