Conversation
Replace the previous ngTabs/ngTab implementation in users.component.html with ng-bootstrap's ngbNav/ngbNavItem/ngbNavContent and an ngbNavOutlet for rendering tab content. Update users.component.ts to import and declare NgbNavModule and remove the removed @angular/aria tab imports. Also remove the @angular/aria peerDependency from the package.json for the identity package. These changes migrate the users UI to use ngbNav for tabbing and keep existing form/roles markup and localization intact.
Replace custom tabs with NgbNav; add NgbNavModule
voloagent
approved these changes
Mar 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This auto-generated PR merges dev into rel-10.2 for the Angular Identity package, updating the Users modal UI to use ng-bootstrap navigation tabs and removing the no-longer-needed @angular/aria peer dependency from the identity package.
Changes:
- Replaced
@angular/aria/tabsusage withngbNav(ng-bootstrap) in the Users modal. - Updated the Users component to import
NgbNavModule. - Removed
@angular/ariapeer dependency from@abp/ng.identity.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| npm/ng-packs/packages/identity/src/lib/components/users/users.component.ts | Swaps out aria tabs imports for NgbNavModule and registers it in the component imports. |
| npm/ng-packs/packages/identity/src/lib/components/users/users.component.html | Reworks the tab markup from aria tabs to ngbNav + outlet. |
| npm/ng-packs/packages/identity/package.json | Removes now-unused @angular/aria peer dependency from the identity package. |
Comment on lines
+31
to
+33
| <ul ngbNav #newUserNav="ngbNav" class="nav-tabs" [(activeId)]="selectedTab"> | ||
| <li ngbNavItem="user-info"> | ||
| <a ngbNavLink>{{ 'AbpIdentity::UserInformations' | abpLocalization }}</a> |
There was a problem hiding this comment.
The template reference variable newUserNav is misleading since the modal is used for both creating and editing users. Consider renaming it to a more generic name (e.g., nav/userNav) and updating the [ngbNavOutlet] binding accordingly to improve readability and avoid future confusion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR generated automatically to merge dev with rel-10.2. Please review the changed files before merging to prevent any errors that may occur.