Angular - Implementing the CMS Kit module features #24234
+56,793
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fahrigedik
approved these changes
Dec 5, 2025
| private route = inject(ActivatedRoute); | ||
| private destroyRef = inject(DestroyRef); | ||
|
|
||
| form: FormGroup; |
Member
There was a problem hiding this comment.
I think we should use the signal-based forms that will come with Angular 21 in the future. Just an idea.
Contributor
Author
There was a problem hiding this comment.
Sure, I checked that either 🙌🏻. However, we need to update the apps to the ng v21 accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves https://github.com/volosoft/volo/issues/20975 and relates https://github.com/volosoft/volo/pull/21014
Features covered in this PR
Checklist
How to test it?