Fix missing strip_root behavior in Codebase return path#4711
Open
Kaushik-Kumar-CEG wants to merge 2 commits intoaboutcode-org:developfrom
Open
Fix missing strip_root behavior in Codebase return path#4711Kaushik-Kumar-CEG wants to merge 2 commits intoaboutcode-org:developfrom
Kaushik-Kumar-CEG wants to merge 2 commits intoaboutcode-org:developfrom
Conversation
Signed-off-by: Kaushik <kaushikrjpm10@gmail.com>
447a642 to
5c4dfb8
Compare
Signed-off-by: Kaushik <kaushikrjpm10@gmail.com>
5c4dfb8 to
956183e
Compare
Author
|
@JonoYang This PR is ready for review The issue was that The fix rebuilds Kindly review my fix and let me know if you have any feedback :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2985
Summary
Fixed
strip_rootparameter not stripping root directory from Resource paths when usingcli.run_scan()programmatically.Problem
--strip-rootworked correctlyreturn_codebase=Truedid not strip root from Resource pathsCodebaseobject instead of JSONSolution
resources_by_pathwith stripped paths after Codebase creationstrip_first_path_segment()to remove root prefix from each ResourceResource.parent()method to return root Resource (not empty string) for direct children of root by monkey-patching whenstrip_rootis enabledChanges
src/scancode/cli.py: Added path stripping logic and parent() fix forreturn_codebasebranchVerification
--strip-rootflagResource.parent(codebase)correctly returns root Resource for direct childrenScreenshots of Fix
BEFORE fix:

AFTER Fix

Tasks
Run tests locally to check for errors.