-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new attributes for curations #539
base: develop
Are you sure you want to change the base?
Conversation
Adds two new attributes: - deployed_resource - is_curated These are used to curate resources in deployed code. Reference: aboutcode-org/scancode.io#834 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@AyanSinhaMahapatra and @pombredanne Can you elaborate a bit what is the different between the
Is the above referencing a directory named |
Is the intent for deployed_resource to describe the name of the component when it is deployed as opposed to denoting that it is Deployed in a particular context? |
Oh... so is it referring something like ?
|
In the context of d2d, we are now also using ABOUT files to map to resources on the deployed side, as curations. #539 (comment) is correct, here ABOUT files which are there in the development codebase side-by-side with the files is different from curation ABOUT files, which are there also in the developement codebase in a location where the code is being built from, but maps to the deployed side. Some examples are patched jars, specific resources built from other sources and other packages. To be able to distinguish between these two types of ABOUT files we need the Now we are using patterns to map to deployed resource paths, and this is also different from the about_resource field in the ABOUT spec as this is resources in the deployed side, and not present side-by-side in the devel codebase. We are currently using The example doc here can be improved to explain more on this all right, let me add that too.
Yes. And also the location where it is deployed through patterns (for now atleast, we can use checksums too later), so we map it correctly. |
We need to discuss this more. |
@AyanSinhaMahapatra and I had a session and came up with this update approach This would mean adding a new optional attribute called |
Adds two new attributes:
deployed_resource
is_curated
These are used to curate resources in deployed code.
Reference: aboutcode-org/scancode.io#834