-
Notifications
You must be signed in to change notification settings - Fork 46
[WEB-4862] - Fix Unenveloped publish code #3064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe changes fix documentation issues by adding 'json' as a utility language to prevent formatting warnings and standardizing curl authentication examples across REST API documentation, converting from a malformed format to proper -u syntax. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
Comment |
e522f47 to
25a41ea
Compare
25a41ea to
9006c48
Compare
kennethkalmer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another thing Matt reported was that copying the code does not give you the full API keys, you get the masked keys back... I need to poke around some of the other code snippets just to check as well (and to see if this is a safari thing or not)
| ```shell | ||
| curl -X POST https://main.realtime.ably.net/channels/rest-example/messages?enveloped=false \ | ||
| -H 'content-type: text/plain' --data 'some plain text' \ | ||
| -u "{'{{API_KEY}}'}"{""} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would scan this file for other API keys that have this ghost {""} afterwards and remove them too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @kennethkalmer I have updated let me know what you think?
9006c48 to
77b3f35
Compare
77b3f35 to
0775559
Compare
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
thanks @kennethkalmer I also checked seems its working on Safari |
|
hi @GregHolmes I updated the whole file with correct API key format. would you be able to re-review it if all good in your end? thanks |
franrob-projects
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kennethkalmer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spotted a tiny mistake on one of the curl lines, otherwise looking good. @aralovelace I think it might be worth asking botticus to "ensure the indentation of the all the fenced code blocks, specifically shell code blocks are consistent and will present well in a fix-width font"
thanks @kennethkalmer for the review. I have updated the indention and some remove unecessary : and \ at the end |
kennethkalmer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one @aralovelace 💅. Please squash down and rebase so we can get this out ![]()
f0dfe32 to
238b2cd
Compare
238b2cd to
982cd2a
Compare
Description
WEB-4862 This is a bug reports from Matt with some issues:
1- the the curl command scripts in this page - https://ably.com/docs/api/rest-api#unenveloped I tried to correct the issues in the format of the codes
2- JSON code cant be copied and paste when clicking the copy icon
MDXWrapper.tsx,theUTILITY_LANGUAGESlist that bypasses language processing only includes ['html', 'xml', 'css', 'sql'] - but not json. This means JSON blocks go through the SDK/language handling logic which may be interfering with the copy functionality. So I have added it back and it workslet me know what you guys think
To Test:
Review app - https://ably-docs-web-4862-fix-ic3sjks.herokuapp.com/docs/api/rest-api#unenveloped
1- Check the Unenveloped publish curl json and plain text codes
2- In this section - https://ably-docs-web-4862-fix-ic3sjks.herokuapp.com/docs/api/rest-api#update-message you should now be able to copy and paste JSON code
Checklist
Summary by CodeRabbit
Bug Fixes
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.