Skip to content

Conversation

@VeskeR
Copy link
Contributor

@VeskeR VeskeR commented Dec 19, 2025

Description

Uses Path-based API from https://github.com/ably/ably-js/releases/tag/2.16.0.
Related to https://ably.atlassian.net/browse/AIT-31

Checklist

@coderabbitai
Copy link

coderabbitai bot commented Dec 19, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mschristensen
Copy link
Contributor

Ok, this works when running the examples directly, but there appears to be an issue with running the map example in sandpack. I created a ticket with what I have found: https://ably.atlassian.net/browse/AIT-230

This needs to be fixed before this is merged. cc @VeskeR

Copy link
Contributor

@mschristensen mschristensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VeskeR VeskeR added the review-app Create a Heroku review app label Dec 22, 2025
@VeskeR VeskeR force-pushed the liveobjects/update-examples-to-path-api branch from 4589605 to 6958944 Compare January 9, 2026 12:36
@VeskeR VeskeR force-pushed the liveobjects/update-examples-to-path-api branch from 6958944 to 0fa37b5 Compare January 9, 2026 12:39
@VeskeR
Copy link
Contributor Author

VeskeR commented Jan 9, 2026

@mschristensen https://ably.atlassian.net/browse/AIT-230 ended up being an issue related to how our sandpack bundling/build is configured for examples pages (see slack thread), which causes any generator functions to return empty when using spread operator or for..of loop.
As a workaround to unblock this PR, wrapped our .entries() call with Array.from() which solves the issue until it's properly fixed (see https://github.com/ably/docs/compare/458960591a97721584359ff6a18c053780ce864e..69589449541cc69823772228613f1c1a146ad3b0).
Please take a second look at the PR and let me know if you're good to merge.

@VeskeR VeskeR requested a review from mschristensen January 9, 2026 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-app Create a Heroku review app

Development

Successfully merging this pull request may close these issues.

3 participants