-
Notifications
You must be signed in to change notification settings - Fork 46
Update LiveObjects examples to use the new Path-based API #3046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Ok, this works when running the examples directly, but there appears to be an issue with running the map example in sandpack. I created a ticket with what I have found: https://ably.atlassian.net/browse/AIT-230 This needs to be fixed before this is merged. cc @VeskeR |
mschristensen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #3046 (comment)
4589605 to
6958944
Compare
Updates our examples for AIT-31
6958944 to
0fa37b5
Compare
|
@mschristensen https://ably.atlassian.net/browse/AIT-230 ended up being an issue related to how our sandpack bundling/build is configured for examples pages (see slack thread), which causes any generator functions to return empty when using spread operator or for..of loop. |
Description
Uses Path-based API from https://github.com/ably/ably-js/releases/tag/2.16.0.
Related to https://ably.atlassian.net/browse/AIT-31
Checklist