DRAFT: Introduction of templates #105
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| const otherMembers = await space.members.getOthers() | ||
| document.getElementById('avatars').style.width = calculateTotalWidth(otherMembers) |
There was a problem hiding this comment.
319 lines of code in an example IMHO feels too long. What are your thoughts here?
| ); | ||
| }; | ||
|
|
||
| export default Avatars; |
There was a problem hiding this comment.
I understand we want less files, and I am on board with this, but now we have very long files that are harder to understand. Given these examples are meant to be read and understood by devs, I am concerned this is too complicated.
ttypic
reviewed
Aug 6, 2024
There was a problem hiding this comment.
I would suggest using typescript, I think it's a standard now and our ICP would expect code samples in typescript
This reverts commit 6c35004.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.