Skip to content

Commit

Permalink
make health_check_protocol required if health_check_path or successfu…
Browse files Browse the repository at this point in the history
…l_response_codes is set (ansible-collections#1354)

elb_target_group make health_check_protocol required if health_check_path or successful_response_codes is set

fixes: ansible-collections#29
SUMMARY
health_check_path and successful_response_codes were previously silently dropped on the floor if health_check_protocol wasn't set.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
elb_target_group
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
  • Loading branch information
tremble authored and abikouo committed Sep 18, 2023
1 parent f121c12 commit 809ebd7
Showing 1 changed file with 10 additions and 7 deletions.
17 changes: 10 additions & 7 deletions elb_target_group.py
Original file line number Diff line number Diff line change
Expand Up @@ -931,14 +931,17 @@ def main():
wait_timeout=dict(type='int', default=200),
wait=dict(type='bool', default=False)
)
required_by = dict(
health_check_path=['health_check_protocol'],
successful_response_codes=['health_check_protocol'],
)
required_if = [
['target_type', 'instance', ['protocol', 'port', 'vpc_id']],
['target_type', 'ip', ['protocol', 'port', 'vpc_id']],
['target_type', 'alb', ['protocol', 'port', 'vpc_id']],
]

module = AnsibleAWSModule(argument_spec=argument_spec,
required_if=[
['target_type', 'instance', ['protocol', 'port', 'vpc_id']],
['target_type', 'ip', ['protocol', 'port', 'vpc_id']],
['target_type', 'alb', ['protocol', 'port', 'vpc_id']],
]
)
module = AnsibleAWSModule(argument_spec=argument_spec, required_by=required_by, required_if=required_if)

if module.params.get('target_type') is None:
module.params['target_type'] = 'instance'
Expand Down

0 comments on commit 809ebd7

Please sign in to comment.