You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request addresses the issue where users were unable to log in due to a password comparison failure in the handleUserLogin controller.
The issue was caused by the way the server was returning the data, which was not being handled correctly on the client-side. The updated handleLogin function now includes an additional check to ensure the plaintext password from the form matches the hashed password stored in the database using bcrypt.compare. This resolves the "Invalid credentials" error that users were experiencing during login.
Changes
Updated the handleLogin function to use bcrypt.compare to directly compare the plaintext password from the form with the hashed password stored in the database.
Improved error handling to display a more specific "Invalid credentials" error message to the user if the password comparison fails.
Added additional logging and error handling to the catch block to help with debugging any future issues.
Fixes
Resolves#315 - Login failure due to password comparison issue
The issue was caused by the way the server was returning the data, which was not being handled correctly on the client-side. The updated `handleLogin` function now includes an additional check to ensure the plaintext password from the form matches the hashed password stored in the database using `bcrypt.compare`. This resolves the "Invalid credentials" error that users were experiencing during login.
The reason will be displayed to describe this comment to others. Learn more.
🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better
This pull request addresses the issue where users were unable to log in due to a password comparison failure in the handleUserLogin controller.
The issue was caused by the way the server was returning the data, which was not being handled correctly on the client-side. The updated handleLogin function now includes an additional check to ensure the plaintext password from the form matches the hashed password stored in the database using bcrypt.compare. This resolves the "Invalid credentials" error that users were experiencing during login.
Changes
Updated the handleLogin function to use bcrypt.compare to directly compare the plaintext password from the form with the hashed password stored in the database.
Improved error handling to display a more specific "Invalid credentials" error message to the user if the password comparison fails.
Added additional logging and error handling to the catch block to help with debugging any future issues.
Fixes
Resolves #315 - Login failure due to password comparison issue
Still not working. can you share the video of login steps
@abhishekraoas Despite my attempts to resolve the issue, I have not been able to fully fix the problem yet. I apologize for not being able to resolve this, Thank you for your understanding.
@abhishekraoas Despite my attempts to resolve the issue, I have not been able to fully fix the problem yet. I apologize for not being able to resolve this, Thank you for your understanding.
@abhishekraoas Despite my attempts to resolve the issue, I have not been able to fully fix the problem yet. I apologize for not being able to resolve this, Thank you for your understanding.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Description
This pull request addresses the issue where users were unable to log in due to a password comparison failure in the
handleUserLogincontroller.The issue was caused by the way the server was returning the data, which was not being handled correctly on the client-side. The updated
handleLoginfunction now includes an additional check to ensure the plaintext password from the form matches the hashed password stored in the database usingbcrypt.compare. This resolves the "Invalid credentials" error that users were experiencing during login.Changes
handleLoginfunction to usebcrypt.compareto directly compare the plaintext password from the form with the hashed password stored in the database.catchblock to help with debugging any future issues.Fixes
Resolves #315 - Login failure due to password comparison issue