-
Notifications
You must be signed in to change notification settings - Fork 283
[Feature] Install necessary packages #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shangeth
wants to merge
8
commits into
abhishekkrthakur:master
Choose a base branch
from
shangeth:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ec9874c
Update code.py
shangeth 933570c
Update code.py
shangeth be42646
Update README.md
shangeth ee0250f
Update README.md
shangeth 92648a3
added logging; removed extra subprocess import
shangeth b4d72d9
Merge branch 'master' into master
shangeth 01c1441
Merge branch 'master' into master
shangeth acc3112
Merge branch 'master' into master
shangeth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,7 +1,9 @@ | ||||||||||
| import os | ||||||||||
| import subprocess | ||||||||||
| from pyngrok import ngrok | ||||||||||
|
|
||||||||||
| import sys | ||||||||||
| import logging | ||||||||||
| logging.basicConfig(filename='colabcode.log',level=logging.INFO) | ||||||||||
| try: | ||||||||||
| from google.colab import drive | ||||||||||
|
|
||||||||||
|
|
@@ -14,15 +16,20 @@ | |||||||||
|
|
||||||||||
|
|
||||||||||
| class ColabCode: | ||||||||||
| def __init__(self, port=10000, password=None, mount_drive=False): | ||||||||||
| def __init__(self, port=10000, password=None, mount_drive=False, packages=None): | ||||||||||
|
|
||||||||||
| self.port = port | ||||||||||
| self.password = password | ||||||||||
| self._mount = mount_drive | ||||||||||
| self._install_code() | ||||||||||
| self._install_extensions() | ||||||||||
| self._start_server() | ||||||||||
| self.packages = packages | ||||||||||
| if self.packages: | ||||||||||
| self._install_packages() | ||||||||||
| self._run_code() | ||||||||||
|
|
||||||||||
|
|
||||||||||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. some extra space? would be nice to get rid of this |
||||||||||
|
|
||||||||||
| def _install_code(self): | ||||||||||
| subprocess.run( | ||||||||||
| ["wget", "https://code-server.dev/install.sh"], stdout=subprocess.PIPE | ||||||||||
|
|
@@ -58,3 +65,8 @@ def _run_code(self): | |||||||||
| ) as proc: | ||||||||||
| for line in proc.stdout: | ||||||||||
| print(line, end="") | ||||||||||
|
|
||||||||||
| def _install_packages(self): | ||||||||||
| for package in self.packages: | ||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
| logging.info(f'Installing {package}...') | ||||||||||
| subprocess.check_call([sys.executable, "-m", "pip", "install", package]) | ||||||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.