fix: accept embeddings= alias and warn on unknown Llama kwargs#2345
Open
Solaris-star wants to merge 1 commit into
Open
fix: accept embeddings= alias and warn on unknown Llama kwargs#2345Solaris-star wants to merge 1 commit into
Solaris-star wants to merge 1 commit into
Conversation
The constructor historically used embedding=True. Callers that pass embeddings=True (plural) were silently swallowed by **kwargs, so embed() later raised a confusing RuntimeError. Accept embeddings as an alias, reject conflicting values, and warn on unexpected kwargs. Fixes abetlen#2210 Signed-off-by: Solaris-star <820622658@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Llama()historically takesembedding=True. Callers that pass the pluralembeddings=True(or other typos) hit a bare**kwargssink: the flag is silently ignored, then.embed()fails later with a misleadingRuntimeError.Changes
embeddings: Optional[bool] = Noneas an alias ofembeddingembedding/embeddingsvaluesUserWarningfor unexpected kwargs instead of swallowing them silently.embed()error message to mention both spellingsFixes #2210
Test plan
tests/test_llama.py::test_embeddings_kwarg_alias_and_unknown_kwargsadded