Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TestOnPRs part of minimal template #338

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Conversation

abelsiqueira
Copy link
Owner

The intrusive part of TestOnPRs is the ReusableTest, which is already
added in the minimal. So we might as well benefit from it and have the
improved PR testing.
This removes the question and fix the files accordingly.

Closes #312

Breaking change: Question SimplifiedPRTest is removed. If you chose
recommended or explicitly answered it as true, nothing changes.
If you chose minimum or explicitly answered it as false, you will have a
new file .github/workflows/TestOnPRs.yml and your Test.yml will change.
Pull Requests will run on a smaller matrix now. See the docs for more
information.

The intrusive part of TestOnPRs is the ReusableTest, which is already
added in the minimal. So we might as well benefit from it and have the
improved PR testing.
This removes the question and fix the files accordingly.

Closes #312

Breaking change: Question SimplifiedPRTest is removed. If you chose
recommended or explicitly answered it as true, nothing changes.
If you chose minimum or explicitly answered it as false, you will have a
new file .github/workflows/TestOnPRs.yml and your Test.yml will change.
Pull Requests will run on a smaller matrix now. See the docs for more
information.
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e96f3be) to head (ca265da).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #338   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           57        57           
=========================================
  Hits            57        57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abelsiqueira abelsiqueira merged commit d05e649 into main Jul 8, 2024
7 checks passed
@abelsiqueira abelsiqueira deleted the 312-test-on-pr-minimal branch July 8, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Make TestOnPRs part of minimal
1 participant