workflows: fix doc generation check #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes abelsiqueira#322 GH runs custom steps as `bash -e` (`errexit`), which means any command failure leads to the shell terminating. To simplify this complexity, factor out to a dedicated script, which we can now also check with shellcheck.
abelsiqueira
approved these changes
Jul 7, 2024
|
@allcontributors please add @suvayu for code |
|
I've put up a pull request to add @suvayu! 🎉 |
This was referenced Jul 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GH runs custom steps as
bash -e(errexit), which means any commandfailure leads to the shell terminating. To simplify this complexity,
factor out to a dedicated script, which we can now also check with
shellcheck.
TestGeneratedPkgs on my fork ✅
Note:
shellchecksays the last line could beif ! cmd, but for this script that would be rather cumbersome, so I ignored it. (SC2181)Related issues
Closes #322
Checklist