Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Workflow TestGeneratedPkg is failing #322

Closed
abelsiqueira opened this issue Jul 4, 2024 · 2 comments · Fixed by #329
Closed

[Bug] Workflow TestGeneratedPkg is failing #322

abelsiqueira opened this issue Jul 4, 2024 · 2 comments · Fixed by #329
Assignees
@abelsiqueira
Labels
bug Something isn't working

Comments

@abelsiqueira
Copy link
Owner

Description

https://github.com/abelsiqueira/BestieTemplate.jl/actions/runs/9791208002

Package Version

NA

Julia Version

NA

Reproduction steps

https://github.com/abelsiqueira/BestieTemplate.jl/actions/runs/9791208002

Relevant log output

No response

Operating System

No response
@abelsiqueira abelsiqueira added the bug Something isn't working label Jul 4, 2024
@abelsiqueira abelsiqueira self-assigned this Jul 4, 2024
abelsiqueira added a commit that referenced this issue Jul 4, 2024
@abelsiqueira
Add git commands to TestGeneratedPkg workflow and fix deving the pkg
88ad726 
Documenter looks for the package in the registry unless it is
pkg> dev'ed.
makedocs makes use of git information, so we create a git repo with
a commit and a remote.
Also changes the PackageOwner to someone that does not exist.

Closes #322
This was referenced Jul 4, 2024
Closed
Merged
abelsiqueira added a commit that referenced this issue Jul 4, 2024
@abelsiqueira
Add git commands to TestGeneratedPkg workflow and fix deving the pkg
6e15973 
Documenter looks for the package in the registry unless it is
pkg> dev'ed.
makedocs makes use of git information, so we create a git repo with
a commit and a remote.
Also changes the PackageOwner to someone that does not exist.

Closes #322
@abelsiqueira abelsiqueira mentioned this issue Jul 4, 2024
Closed
@suvayu
Copy link
Collaborator

suvayu commented Jul 4, 2024 •
edited
Loading

The failure is strange since I was expecting failure would print out the names of the files that are missing (output of ... | grep missing). Maybe some other kind of error is happening?

@suvayu
Copy link
Collaborator

suvayu commented Jul 4, 2024 •
edited
Loading

Found it! It's because the shell is invoked as bash -e, which always fails whenever a command fails; see (bash) The Set Builtin! We need a different way to detect this 🤔

suvayu added a commit to suvayu/COPIERTemplate.jl that referenced this issue Jul 4, 2024
@suvayu
workflows: fix doc generation check
a9fcdff 
Fixes abelsiqueira#322

GH runs custom steps as `bash -e` (`errexit`), which means any command
failure leads to the shell terminating.  To simplify this complexity,
factor out to a dedicated script, which we can now also check with
shellcheck.
@suvayu suvayu mentioned this issue Jul 4, 2024
Merged
5 tasks
abelsiqueira pushed a commit that referenced this issue Jul 7, 2024
@suvayu @abelsiqueira
workflows: fix doc generation check
ede1175 
Fixes #322

GH runs custom steps as `bash -e` (`errexit`), which means any command
failure leads to the shell terminating.  To simplify this complexity,
factor out to a dedicated script, which we can now also check with
shellcheck.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abelsiqueira abelsiqueira

Labels
bug Something isn't working
Projects
BestieTemplate.jl
Status: Done
Milestone
No milestone
2 participants
@suvayu @abelsiqueira