Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file format guidelines #203

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Add file format guidelines #203

merged 2 commits into from
Feb 8, 2024

Conversation

mbtools
Copy link
Member

@mbtools mbtools commented Jan 25, 2024

No description provided.

@albertmink
Copy link
Member

Good idea, but I am not sure whether this is checked. In .abap files I observed a lot of no empty lines as most recently in https://github.com/BeckerWdf/abapGit/blob/5959ed6a774beef3080e73312b17b2237707b2c1/src/objects/aff/zcl_abapgit_object_drty.clas.abap.
In PR the icon at the end of a file, as this one, shows that there is no empty line.
Screenshot 2024-01-25 at 13 29 10

@mbtools
Copy link
Member Author

mbtools commented Jan 25, 2024

it's not checked but will caused diffs. i try to keep an eye on it until abaplint does it automatically but sometimes things slip through.

@mbtools mbtools merged commit f5f6b9c into main Feb 8, 2024
@mbtools mbtools deleted the mbtools/file_format branch February 8, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants