Add ABAP Language Version

[mbtools]

After #183

Ref abapGit/abapGit#6154

Ref #184

[larshp]

see comments

[mbtools]

I will make a table for the different combinations.

[schneidermic0]

Thanks, @mbtools for the documentation of ABAP language version in abapGit.

Look quite good to me. 👍 I have just added some comments

[schneidermic0]

Thanks, for the update. I have just some small comments.

[schneidermic0]

I think the setting "Any" has not been supported by the AFF object super class, yet. Currently, it removes the ABAP language version always.

[mbtools]

I changed the AFF logic already to remove ALaV only in "ignore mode"

https://github.com/abapGit/abapGit/blob/931e4c1006f4fa3947718686966b06579b4d8b47/src/objects/aff/zcl_abapgit_object_common_aff.clas.abap#L620-L623

This way, the files will be compatible between abapGit and ADT.

PS: Doing more testing and bug fixing.

[schneidermic0]

I changed the AFF logic already to remove ALaV only in "ignore mode"

Ah, good to know. 👍 But one more question: In the documentation it is stated the ABAP LV is also not serialized if the repository is set to a specific version:

docs.abapgit.org/src/user-guide/reference/abap-lanuage-version.md

Line 79 in 9a7d8c1

When serializing objects, the ABAP language version will **not* be part of the metadata of each object.

I guess we either need to adapt documentation or AFF logic should be remove ABAP LV only if the setting is "Any". What do you think?

[mbtools]

Let's always keep ALaV, for XML and JSON formats, except for the "ignore mode". Then it's clear what you get by just looking at the file. We won't need any mapping when deserializing and can check if the object fits the repo setting. Better?

BTW, SAP did not include ABAP_LANGUAGE_VERSION in any DDIC views (DD0xV). Too scared to break something? 😜
That's why it's not included in any of the current DDIC XMLs. It will take some extra logic to add it.

[schneidermic0]

Yes, this is fine for me :)

[mbtools]

I added a section about supported object types. This should be good to go

[albertmink]

Hmm, there are still some ABAP Language Versions around in the PR, for which I provided SUGGESTIONS. I didn't check the entire files, so maybe there are some left overs there as well.

[mbtools]

Thanks for the corrections 👍

[schneidermic0]

Looks good to me. Just one more question regarding supported object types but we can add these later.

[larshp]

👍

[mbtools]

@larshp you just need to update your review 😉 🙏

[larshp]

done, sorry

[schneidermic0]

Thanks @mbtools for your efforts 👍