-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mem leak fix when new upstreams are added #7
Open
cinquemb
wants to merge
44
commits into
abadcafe:master
Choose a base branch
from
cinquemb:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ace the old old processes
…bad free, prob need reference counting
…bad free, prob need reference counting
Update after ~3 days with latest changes with no restarts in between:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to avoid append to the existing ngx_conf_t pool, this will create a temp ngx_conf_t pool in refresh_upstream, swap old one out and delete if upstreams change.
This also implements some of the changes similar to what https://github.com/GUI/nginx-upstream-dynamic-servers/pull/33/files (no need for exit_procces, using ngx_http_upstream_init_round_robin instead of init), but avoids having to count refs to pools to address the leak.
Still leaks mem, but way less now.
Sample after ~12 hours with 2 upstreams, and about 82 different nginx servers: