Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails Capstone: Final Version #7

Merged
merged 84 commits into from
Sep 23, 2023
Merged

Rails Capstone: Final Version #7

merged 84 commits into from
Sep 23, 2023

Conversation

ab-noori
Copy link
Owner

Capstone finance tracker app: Final Version

🌟Features:

  • - Implementation of a splash screen featuring the app's name and links to sign-up and log-in pages is completed.
  • - User registration functionality is integrated, requiring input for full name, email, and password as mandatory fields.
  • - Access restrictions were applied to prevent non-logged-in users from accessing protected pages.
  • - The home page displays categories along with their names, icons, and total transaction amounts.
  • - Navigation to specific transaction pages is enabled by clicking on a category item.
  • - The addition of a user-friendly "Add a new category" button streamlines the category creation process.
  • - Transaction pages are designed to list transactions, ordered by the most recent, with the total category amount.
  • - PostgreSQL was selected as the database management system.
  • - The project was deployed online, ensuring accessibility for users.
  • - Proper attribution in compliance with the Creative Commons license for the original design by Gregoire Vella on Behance is provided in the README.

Copy link

@Whoistolu Whoistolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ab-noori

Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

Highlight

🔆 Project well documented and deployed
🔆 Devise well installed, I could sign up and sign in
🔆 When the user logs in, they are presented with the categories page
🔆 For a given category, the list of transactions is presented ordered by the most recent
🔆 A user can add new transactions for a given category

Required Changes ♻️

  • Check the inline comments under the review for sections to improve.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @Whoistolu in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

README.md Outdated

## 🚀 Live Demo & Project intro <a name="live-demo"></a>
- [Live Demo on Render](https://finance-tracker-kxhn.onrender.com/)
- [Introduction to the project](https://www.loom.com/share/928b45d5bd4c45d4bc95497e9ccc442f?sid=4e1fcb03-dfd3-4891-b610-0ff3c4545693)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • [REQUIRED] Great presentation @ab-noori 🥇 , however, a part of the project requirement states that you should highlight a piece of the code that you are most proud of. Kindly implement this before requesting another review 👍🏽

@@ -0,0 +1,12 @@
class User < ApplicationRecord
# Include default devise modules. Others available are:
# :confirmable, :lockable, :timeoutable, :trackable and :omniauthable

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • [OPTIONAL] I would like to recommend that you enable :confirmable because it adds an additional layer of security to your application by requiring users to verify their email addresses. After users register, they receive a confirmation email with a link. They must click the link to confirm their email address and activate their accounts.

Copy link

@OLIPLICHE OLIPLICHE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ab-noori,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

  • Applied the changes from the previous review(✅)) 👏
  • The App is working fine👏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@ab-noori
Copy link
Owner Author

ab-noori commented Sep 23, 2023

Hi @Whoistolu,
Thanks for reviewing my project.
Your feedback is appreciated 🙏
The requested changes were applied and I have recorded a new video.
But I think it won't be a requirement to highlight a piece of code. If I don't have any piece of code to be proud of 🤦‍♀️, then what should I do 🤔?

Copy link
Owner Author

@ab-noori ab-noori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @OLIPLICHE 👋,
Thank you so much 🙏 for reviewing and approving my pull request.
Your nice feedback is really appreciated 🙏.

Thank-You-Very-Much

@ab-noori ab-noori merged commit 131ce55 into development Sep 23, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants