-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rails Capstone: Final Version #7
Conversation
Project set up
Authentication
Unit and integration tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ab-noori
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlight
🔆 Project well documented and deployed
🔆 Devise well installed, I could sign up and sign in
🔆 When the user logs in, they are presented with the categories page
🔆 For a given category, the list of transactions is presented ordered by the most recent
🔆 A user can add new transactions for a given category
Required Changes ♻️
- Check the inline comments under the review for sections to improve.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @Whoistolu in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
README.md
Outdated
|
||
## 🚀 Live Demo & Project intro <a name="live-demo"></a> | ||
- [Live Demo on Render](https://finance-tracker-kxhn.onrender.com/) | ||
- [Introduction to the project](https://www.loom.com/share/928b45d5bd4c45d4bc95497e9ccc442f?sid=4e1fcb03-dfd3-4891-b610-0ff3c4545693) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [REQUIRED] Great presentation @ab-noori 🥇 , however, a part of the project requirement states that you should highlight a piece of the code that you are most proud of. Kindly implement this before requesting another review 👍🏽
@@ -0,0 +1,12 @@ | |||
class User < ApplicationRecord | |||
# Include default devise modules. Others available are: | |||
# :confirmable, :lockable, :timeoutable, :trackable and :omniauthable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [OPTIONAL] I would like to recommend that you enable
:confirmable
because it adds an additional layer of security to your application by requiring users to verify their email addresses. After users register, they receive a confirmation email with a link. They must click the link to confirm their email address and activate their accounts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ab-noori,
Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉
Highlights
- Applied the changes from the previous review(✅)) 👏
- The App is working fine👏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Hi @Whoistolu, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @OLIPLICHE 👋,
Thank you so much 🙏 for reviewing and approving my pull request.
Your nice feedback is really appreciated 🙏.
Capstone finance tracker app: Final Version
🌟Features: