-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EduPlanner π BackEnd application V.1.0.0 𧱠#24
Conversation
Project Setup π¦
and Create the courese model using scaffold.
β¦oori/EduPlanner-Backend into feature/models-and-database
β¦oori/EduPlanner-Backend into feature/models-and-database
β¦oori/EduPlanner-Backend into feature/models-and-database
Creating Models and Database Schema πΊοΈ
Creating controllers and routings
β¦into Fix/user-controller
Creating the form for adding a new course π
add api documentation
Create Unit Tests π§ͺ For Application Models π½
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @gisachris ,
Good job so far!
There are some issues that you still need to work on to prepare your project for the final evaluation, but you are almost there!
To highlight:
- Tests are passingβοΈ
- Nice code organization βοΈ
- API is working wellβοΈ
- Good readme βοΈ
You are really close to finishing the Microverse program!! Keep it up! πππ
After implementing the requested changes, please submit another review request. β»οΈ
Check the comments under the review.
Cheers and Happy coding!πππ
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the previous reviews unless it is requested otherwise.
README.md
Outdated
|
||
## π License <a name="license"></a> | ||
|
||
This project is [MIT](./MIT.md) licensed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
- **Can I use this repository?** | ||
|
||
Please feel free to fork this repository for your own projects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- You are using Rspec, but the "test" folder still exists, which is used by another test framework. Kindly consider deleting that folder if you are not using it. π
def destroy | ||
@reservation.destroy | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- What happens is the reservation is not successfully destroyed? Kindly, add some error handling. π
Hi @Meltrust π, |
Deployment π
IN This PR We present the Edu Planner Appointments Application Required Changes(Backend): β»οΈThis application has undergone Making changes β»οΈ and has completed Successfully Changes Required
ACHIEVEMENTS β°οΈ
ConclusionWe would love to hear π from you Our CR in terms of what can be better implemented π¨βπ» for the site thank you! And we look forward to hearing from you soon. π |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @gisachris,
Wow, you did it π
Thank you for the changes implemented πͺ π₯ γοΈ
Unless you want to add more features, go ahead to your final presentation β© β© β©
You are about to finish the Microverse program. You have come a long way!!!
Good luck in the software industry!! I'll see you there. β¨
Congratulations!!!!!! π
Cheers and Happy coding!πππ
@Meltrust Thank you for the kind review π€ |
IN This PR We present the Edu Planner Appointments Application:π
This BackEnd Part of the application has undergone its development π¨βπ» phase and completed successfully
Project KanBan Board
Requirements
ACHIEVEMENTS β°οΈ
NOTE
Groups of three
.Conclusion
We would love to hear π from you Our CR in terms of what can be better implemented π¨βπ» for the site thank you! And we look forward to hearing from you soon. π