Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EduPlanner πŸ“† BackEnd application V.1.0.0 🧱 #24

Merged
merged 59 commits into from
Oct 13, 2023
Merged

Conversation

gisachris
Copy link
Collaborator

IN This PR We present the Edu Planner Appointments Application:🌐

This BackEnd Part of the application has undergone its development πŸ‘¨β€πŸ’» phase and completed successfully

Project KanBan Board

board

Requirements

  • All requirements can be found here

ACHIEVEMENTS ⛰️

  • Application has a fully built and well-designed UI🎨 and UXβš™οΈ system ready to fulfill all these requirements
  • Link To Application FrontEnd Deployed app here
  • Link To Application BackEnd Deployed app here
  • Link to Application FrontEnd SourceCode here

NOTE

  • In this Project We worked As a Team Of three (@gisachris , @ab-noori , @BANCUNGUYE66 ) and Implemented the Project Requirements to the Best of our Abilities and According to the Project Requirements for a Groups of three.

Conclusion

We would love to hear πŸ‘‚ from you Our CR in terms of what can be better implemented πŸ‘¨β€πŸ’» for the site thank you! And we look forward to hearing from you soon. πŸ™‡

gisachris and others added 30 commits September 29, 2023 11:07
 and Create the courese model using scaffold.
Creating Models and Database Schema πŸ—ΊοΈ
Copy link

@Meltrust Meltrust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gisachris ,

Good job so far!
There are some issues that you still need to work on to prepare your project for the final evaluation, but you are almost there!

To highlight:

  • Tests are passingβœ”οΈ
  • Nice code organization βœ”οΈ
  • API is working wellβœ”οΈ
  • Good readme βœ”οΈ

You are really close to finishing the Microverse program!! Keep it up! πŸ‘πŸ‘πŸ‘

You can do it

After implementing the requested changes, please submit another review request. ♻️

Check the comments under the review.

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the previous reviews unless it is requested otherwise.


README.md Outdated

## πŸ“ License <a name="license"></a>

This project is [MIT](./MIT.md) licensed.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • This link to the LICENSE file does not work. Kindly, link to the correct file to correct it. πŸ‘

image


- **Can I use this repository?**

Please feel free to fork this repository for your own projects.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • You are using Rspec, but the "test" folder still exists, which is used by another test framework. Kindly consider deleting that folder if you are not using it. πŸ‘

Comment on lines 54 to 56
def destroy
@reservation.destroy
end

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • What happens is the reservation is not successfully destroyed? Kindly, add some error handling. πŸ‘

@ab-noori
Copy link
Owner

Hi @Meltrust πŸ‘‹,
Thank you so much πŸ™ for reviewing our pull request.
Your nice feedback is really appreciated πŸ™.
Our team will work on the requested changes 🎯

thank-you-gif-22

@gisachris
Copy link
Collaborator Author

IN This PR We present the Edu Planner Appointments Application Required Changes(Backend): ♻️

This application has undergone Making changes ♻️ and has completed Successfully

Changes Required

  • Implement Error handling on the Backend of the Application.
  • Remove MiniTest files since we are using Rspec for Testing. πŸ§ͺ
  • Put Proper links to Licence file πŸ“œ

ACHIEVEMENTS ⛰️

  • All the Above Where achieved. βœ…

Conclusion

We would love to hear πŸ‘‚ from you Our CR in terms of what can be better implemented πŸ‘¨β€πŸ’» for the site thank you! And we look forward to hearing from you soon. πŸ™‡

Copy link

@Meltrust Meltrust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gisachris,

Wow, you did it πŸŽ‰

Brilliant

Thank you for the changes implemented πŸ’ͺ πŸ₯‡ γŠ—οΈ

Unless you want to add more features, go ahead to your final presentation ⏩ ⏩ ⏩

You are about to finish the Microverse program. You have come a long way!!!

Good luck in the software industry!! I'll see you there. ✨

Congratulations!!!!!! πŸŽ‰

applause

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘


@gisachris
Copy link
Collaborator Author

@Meltrust Thank you for the kind review 🀝

@gisachris gisachris merged commit 7e032b3 into main Oct 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants