Fixes to allow building in -std=c++20 mode. #33
Conversation
* Various kinds of math involving enums are deprecated, so replace with constexprs where necessary. * Types on both sides of "==" must match. Bug: chromium:1284275
There was a problem hiding this comment.
The changes themselves look good to me, but this repository may not be the best place to make these changes.
This repository is meant to be just a place to keep different versions of the unrar library hosted so that Chromium can pull it. The true source is: https://www.rarlab.com/rar_add.htm
I can reach out to the real maintainer of unrar to see if they are can merge these changes in their version that Chromium can then use. Would that be OK?
|
Yes, that would be great! Thanks very much. |
|
Any word from upstream? |
|
It looks like the current trunk has taken some of the fixes here (BLAKE_ALIGNMENT and BLAKE_DATA_SIZE are now constexprs and HashValue::operator==() is now const) but not others (the BLAKE2S_ constants are still enums and HashValue::operator!=() still exists, although since it's now marked const it will no longer cause any compilation problems). Did upstream miss the remaining bits, reject them, ...? Wondering what to do with this PR. |
constexprs where necessary.
Bug: chromium:1284275