Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buy It Now + Starting price #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Nokhal
Copy link
Contributor

@Nokhal Nokhal commented Jan 11, 2024

Diamond cut ready (Update OR as new diamond)

Starting price where you prepay the marketplace fees (ie : you only lose money as a seller if there is no bid, no direct impact on final earnings)
Buy it now, giving buyer to instantly settle an auction and win an item if they pay for the asked price.
Ability for the seller to lower the buy it now price or cancel it, but not increase it
New events to easily track those new features from an Indexer (eg: Subgraph)

The code is

Diamond-cut ready, assuming an existing deployment. See comments in the GBMFacetExtensionOne.sol to know what to updated/add
Can also be deployed 'as is' to a completely new diamond
Untested within your UI/UX but have minimized the amount of new functions
fully retro-compatible with any existing flow and API if updating an existing diamond

>Diamond cut ready (Update OR as new diamond)
See comments in GBMFacetExtensionOne for how to cut when updating.
orionstardust added a commit that referenced this pull request Mar 5, 2024
@orionstardust orionstardust mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant