Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Improve Merit tooltip #2389

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

MartinGbz
Copy link
Contributor

General Changes

  • Add ACI logo to tooltip
  • Highlight better the claim link
  • Set campaign link instead of general link (eg: on Sonic USDC.e campaign, the claim link will be https://apps.aavechan.com/merit/sonic-supply-usdce instead of https://apps.aavechan.com/merit
  • Change incentives author name for ACI

Developer Notes

Add any notes here that may be helpful for reviewers.


Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

  • End-to-end tests are passing without any errors
  • Code changes do not significantly increase the application bundle size
  • If there are new 3rd-party packages, they do not introduce potential security threats
  • If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
  • There are no CI changes, or they have been approved by the DevOps and Engineering team(s)

Copy link

vercel bot commented Mar 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
interface-ez7q ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2025 2:26pm

Copy link

vercel bot commented Mar 11, 2025

@MartinGbz is attempting to deploy a commit to the Avara Team on Vercel.

A member of the Team first needs to authorize it.

@foodaka
Copy link
Collaborator

foodaka commented Mar 12, 2025

@MartinGbz please remove the icon and keep the text the way it was before, thanks

@MartinGbz
Copy link
Contributor Author

MartinGbz commented Mar 18, 2025

@MartinGbz please remove the icon and keep the text the way it was before, thanks

As we talked in private last week, I don't really understand why we should remove the ACI logo while we put ZkSync Ignite logos on other tooltips for instance.
I can put the text back as it is, but again it was to highlight better the claim link (as it's only a link, it's kind of hidden to the users)

@foodaka
Copy link
Collaborator

foodaka commented Mar 19, 2025

Copy link

github-actions bot commented Mar 19, 2025

❌ CI run has failed!
Please see logs at https://github.com/aave/interface/actions/runs/13955814273'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants