Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: swap [skip cypress] #2171

Merged
merged 1 commit into from
Sep 2, 2024
Merged

feat: swap [skip cypress] #2171

merged 1 commit into from
Sep 2, 2024

Conversation

foodaka
Copy link
Collaborator

@foodaka foodaka commented Sep 2, 2024

General Changes

  • Enables liquidity swaps and withdraw and swap

Developer Notes

Add any notes here that may be helpful for reviewers.


Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

  • End-to-end tests are passing without any errors
  • Code changes do not significantly increase the application bundle size
  • If there are new 3rd-party packages, they do not introduce potential security threats
  • If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
  • There are no CI changes, or they have been approved by the DevOps and Engineering team(s)

Copy link

height bot commented Sep 2, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

github-actions bot commented Sep 2, 2024

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 544.89 KB (🟡 +3 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Copy link

github-actions bot commented Sep 2, 2024

1 similar comment
Copy link

github-actions bot commented Sep 2, 2024

Copy link

github-actions bot commented Sep 2, 2024

3 similar comments
Copy link

github-actions bot commented Sep 2, 2024

Copy link

github-actions bot commented Sep 2, 2024

Copy link

github-actions bot commented Sep 2, 2024

@foodaka foodaka merged commit 2b64400 into main Sep 2, 2024
16 of 19 checks passed
@foodaka foodaka deleted the feat/re-enable-ls branch September 2, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants