Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add XDEFI Wallet option #1998

Closed
wants to merge 2 commits into from

Conversation

HoangVD2
Copy link

General Changes

  • add XDEFI wallet option

Author Checklist

Please ensure you, the author, have gone through this checklist to ensure there is an efficient workflow for the reviewers.

  • The base branch is set to main
  • The title is using Conventional Commit formatting
  • The Github issue has been linked to the PR in the Development section
  • The General Changes section has been filled out
  • Developer Notes have been added (optional)

If the PR is ready for review:

  • The PR is in Open state and not in Draft mode
  • The Ready for Dev Review label has been added

Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

  • End-to-end tests are passing without any errors
  • Code style generally follows existing patterns
  • Code changes do not significantly increase the application bundle size
  • If there are new 3rd-party packages, they do not introduce potential security threats
  • If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
  • There are no CI changes, or they have been approved by the DevOps and Engineering team(s)
  • Code changes have been quality checked in the ephemeral URL
  • QA verification has been completed
  • There are two or more approvals from the core team
  • Squash and merge has been checked

Copy link

height bot commented Mar 22, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@HoangVD2
Copy link
Author

Hi, Aave team!

This PR adds the XDEFI wallet to the list of supported wallets.

Please let us know if anything needs to be added or changed to satisfy your requirements.

XDEFI Wallet team.

Screen.Recording.2024-03-22.at.15.00.54.mov

@davidp94
Copy link

Thank you @HoangVD2
Maybe @grothem or @marczeller could approve it 🖖 ?

@marczeller
Copy link
Collaborator

I'd love to, but frontend is controlled by Avara, not the DAO.

I've been fighting for a Rabby option for years at this point.

@grothem
Copy link
Collaborator

grothem commented Mar 25, 2024

Thanks for the PR @HoangVD2

We're actually in the process of updating the wallet connection libraries so we're not looking to make any changes to this right now.

Also, regrading the rabby option, it can be used today in the interface by selecting the 'Browser wallet' option in the connection modal. Should be the same with xdefi as well.

@foodaka
Copy link
Collaborator

foodaka commented Aug 2, 2024

wont support at this time

@foodaka foodaka closed this Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants