Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v3-migration.page):APY type change buttons' background color cha… #1952

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

boombb12138
Copy link

@boombb12138 boombb12138 commented Feb 8, 2024

General Changes

Related issue:
[https://github.com/aave/interface/issues/1897](url)

  • Fixes the APY buttons' background color in both light mode and dark mode. These button are in the v3-migration.page

Developer Notes

Add any notes here that may be helpful for reviewers.

before this change the button background is :
image
result in the
image


Author Checklist

Please ensure you, the author, have gone through this checklist to ensure there is an efficient workflow for the reviewers.

If the PR is ready for review:

  • The PR is in Open state and not in Draft mode
  • The Ready for Dev Review label has been added

Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

  • End-to-end tests are passing without any errors
  • Code style generally follows existing patterns
  • Code changes do not significantly increase the application bundle size
  • If there are new 3rd-party packages, they do not introduce potential security threats
  • If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
  • There are no CI changes, or they have been approved by the DevOps and Engineering team(s)
  • Code changes have been quality checked in the ephemeral URL
  • QA verification has been completed
  • There are two or more approvals from the core team
  • Squash and merge has been checked

Copy link

height bot commented Feb 8, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@boombb12138 boombb12138 marked this pull request as draft February 8, 2024 03:31
@boombb12138 boombb12138 marked this pull request as ready for review February 8, 2024 03:31
@foodaka
Copy link
Collaborator

foodaka commented Feb 8, 2024

thanks for the contribution @boombb12138

@boombb12138
Copy link
Author

anyone can help review? Need one more review to perform merge~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants