Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delegation modal #1901

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: delegation modal #1901

wants to merge 6 commits into from

Conversation

grothem
Copy link
Collaborator

@grothem grothem commented Jan 9, 2024

General Changes

  • Replaced radio buttons with checkboxes in delegation/revoke modal since there are 3 assets to choose from
  • Fixed the ens provider so that it works on forks
  • Fixes a bug where the votes weren't sorted correctly when querying from subgraph

Developer Notes

Add any notes here that may be helpful for reviewers.


Author Checklist

Please ensure you, the author, have gone through this checklist to ensure there is an efficient workflow for the reviewers.

  • The base branch is set to main
  • The title is using Conventional Commit formatting
  • The Github issue has been linked to the PR in the Development section
  • The General Changes section has been filled out
  • Developer Notes have been added (optional)

If the PR is ready for review:

  • The PR is in Open state and not in Draft mode
  • The Ready for Dev Review label has been added

Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

  • End-to-end tests are passing without any errors
  • Code style generally follows existing patterns
  • Code changes do not significantly increase the application bundle size
  • If there are new 3rd-party packages, they do not introduce potential security threats
  • If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
  • There are no CI changes, or they have been approved by the DevOps and Engineering team(s)
  • Code changes have been quality checked in the ephemeral URL
  • QA verification has been completed
  • There are two or more approvals from the core team
  • Squash and merge has been checked

Copy link

height bot commented Jan 9, 2024

This pull request has been linked to 2 tasks:

💡Tip: Add "Close T-18684" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

@grothem
Copy link
Collaborator Author

grothem commented Jan 9, 2024

Link T-18684

@grothem
Copy link
Collaborator Author

grothem commented Jan 9, 2024

Link T-18567

Copy link

Copy link

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 518.88 KB (-10 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Six Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 91.95 KB (🟢 -11 B) 610.83 KB
/governance 99.22 KB (-9 B) 618.1 KB
/governance/proposal/[proposalId] 139.59 KB (-7 B) 658.47 KB
/history 50.73 KB (🟢 -17 B) 569.61 KB
/reserve-overview 40.38 KB (🟢 -9 B) 559.27 KB
/v3-migration 48.47 KB (🟢 -12 B) 567.35 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

Copy link

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 523.38 KB (-10 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/governance 100.1 KB (🟡 +1 B) 623.48 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@foodaka foodaka added the Ready for QA Review Ready for QA engineer reviews label Feb 26, 2024
@MareskoY
Copy link
Contributor

Hello @grothem there are few issues here

1. we can deligate assets with 0 amount - i think we don't need to show 0 options
Screenshot 2024-02-28 at 18 50 37
2. if we try to delegate 2 options deliagtion become only for 1st asset
Large GIF (1298x830)
result
Screenshot 2024-02-28 at 18 57 21

@MareskoY MareskoY added QC Failed and removed Ready for QA Review Ready for QA engineer reviews labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants