Skip to content

Commit

Permalink
fix: build (#2133)
Browse files Browse the repository at this point in the history
  • Loading branch information
grothem committed Aug 2, 2024
1 parent 00a3277 commit 0adfc82
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 22 deletions.
20 changes: 0 additions & 20 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,32 +10,12 @@ Add any notes here that may be helpful for reviewers.

---

## Author Checklist

Please ensure you, the author, have gone through this checklist to ensure there is an efficient workflow for the reviewers.

- [ ] The base branch is set to `main`
- [ ] The title is using [Conventional Commit](https://www.conventionalcommits.org/en/v1.0.0/) formatting
- [ ] The Github issue has been linked to the PR in the Development section
- [ ] The General Changes section has been filled out
- [ ] Developer Notes have been added (optional)

**If the PR is ready for review:**

- [ ] The PR is in `Open` state and not in `Draft` mode
- [ ] The `Ready for Dev Review` label has been added

## Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

- [ ] End-to-end tests are passing without any errors
- [ ] Code style generally follows existing patterns
- [ ] Code changes do not significantly increase the application bundle size
- [ ] If there are new 3rd-party packages, they do not introduce potential security threats
- [ ] If there are new environment variables being added, they have been added to the `.env.example` file as well as the pertinant `.github/actions/*` files
- [ ] There are no CI changes, or they have been approved by the DevOps and Engineering team(s)
- [ ] Code changes have been quality checked in the ephemeral URL
- [ ] QA verification has been completed
- [ ] There are two or more approvals from the core team
- [ ] Squash and merge has been checked
2 changes: 1 addition & 1 deletion src/libs/web3-data-provider/WalletConnectConnector.ts
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ export class WalletConnectConnector extends AbstractConnector {
}
}

public async getProvider(): Promise<typeof this.walletConnectProvider> {
public async getProvider(): Promise<EthereumProvider | undefined> {
return this.walletConnectProvider;
}

Expand Down
2 changes: 1 addition & 1 deletion src/libs/web3-data-provider/Web3Provider.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ export const Web3ContextProvider: React.FC<{ children: ReactElement }> = ({ chil
setConnector(connector);

// eslint-disable-next-line @typescript-eslint/no-explicit-any
if ((window as any).ethereum.isFamily) {
if ((window as any).ethereum?.isFamily) {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
(window as any).ethereum.on('chainChanged', (chainId: string | number) => {
// the injected connector relies on the networkChanged event to update the chainId,
Expand Down

1 comment on commit 0adfc82

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit was deployed on ipfs

Please sign in to comment.