Fix dual call issue #376
Closed
Fix dual call issue #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will only be set if the Interactor is being run in the context of an Organizer. If there are several layers of nested Organizers, then the organizer attribute will represent the immediate parent. If this is being run outside of an Organizer (just running the Interactor directly), organizer will be nil.
Previously, this only worked correctly because the caller only invoked "after_perform" callbacks. This goes a step further by only putting after_perform callbacks in this collection.
…zed logic. Previously, if an Organizer was nested inside another Organizer, the after_perform calls were not deferred until after the outermost Organizer had finished running...which somewhat defeats the purpose (at least when nested Organizers). This updates the logic so that if a highly nested after_perform call is deferred, it will be deferred to the very end.
Nested deferment
…h our ruby 3.1.4 application
Remove accommodation made for ruby 2.7 that causes it to not work wit…
If an Interactor that has deferred after_performs is called from an Organizer and then...later...directly, the after_performs are skipped when calling directly. This is due to how Organizers handle Interactors with deferred logic. In such a case, the Organizer modifies the Interactor's callback so that it is skipped. However, this does not account for cases where an Interactor is called both as part of an Organizer and on it's own. In this case, the Interactor believes it should skip handling the after_performs forever, and rely instead on the Organizer to call them at the appropriate time. This change updates the logic so that the callback is only skipped if the organizer property is not present. This property is used to tell the Interactor that and by what it is being "organized".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix dual call issue with interactors with deferred after_performs
If an Interactor that has deferred after_performs is called from an Organizer and then...later...directly, the after_performs are skipped when calling directly.
This is due to how Organizers handle Interactors with deferred logic. In such a case, the Organizer modifies the Interactor's callback so that it is skipped. However, this does not account for cases where an Interactor is called both as part of an Organizer and on it's own. In this case, the Interactor believes it should skip handling the after_performs forever, and rely instead on the Organizer to call them at the appropriate time.
This change updates the logic so that the callback is only skipped if the organizer property is not present. This property is used to tell the Interactor that and by what it is being "organized".
Information
[ ] Contains Documentation[ ] Contains Breaking ChangesFixed