Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cflags fno-exceptions #21

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bryanrasmussen
Copy link

I added in 'cflags!': [ '-fno-exceptions' ],
'cflags_cc!': [ '-fno-exceptions' ], to binding.gyp because if I am trying to process images in a queue and I try to hash an image that is malformed or just not existent or does not have the rights to read for some reason I get something like the following

[CImg] *** CImgIOException *** [instance(0,0,0,0,0x0,non-shared)] CImg::load(): Failed to recognize format of file '/Users/bryan/projects/repositories/secondweownit/weownit/public/uploads/images/54ca/54ca0ac949f1d8c972000005/1223cbTHUMB-chagrin-falls-patriotic-debate.jpg'.
node(7178,0x1055e1000) malloc: *** error for object 0x101040a00: pointer being freed was not allocated
*** set a breakpoint in malloc_error_break to debug

after which my process queue shuts down and I can't keep processing the next images that do work.

If however I can catch the exceptions my queue can register the errors and keep merrily chugging along.

It's not necessarily the best solution, so you may want to do other things to allow processing of errors.

Thanks for your work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant