example/h-sql: improvements and simplifications #368
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asymmetric
force-pushed
the
patch-1
branch
2 times, most recently
from
02d9f6a to
d44447d
Compare
asymmetric
changed the title
asymmetric
commented
Dec 10, 2024
| let query = | ||
| let open Caqti_request.Infix in | ||
| (T.unit ->* T.(tup2 int string)) | ||
| (T.unit ->* T.(t2 int string)) |
There was a problem hiding this comment.
tup2 is deprecated.
asymmetric
force-pushed
the
patch-1
branch
2 times, most recently
from
1b6cc85 to
21e2ea2
Compare
IMO, this improves the examples by: - making the arguments stand out more, by moving them to the top - removing visual clutter from the promise section, which is the focus of the example
asymmetric
force-pushed
the
patch-1
branch
3 times, most recently
from
3784f01 to
c3d1aff
Compare
|
Closing, as I wasn't aware of the promises example. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NB: I'm an OCaml beginner, so some of my improvements might not be seen as such (or as being idiomatic) by more seasoned devs.