Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --sort-by-stats flag to html reporter #433

Merged
merged 3 commits into from
Feb 12, 2024

Conversation

mbarbin
Copy link
Contributor

@mbarbin mbarbin commented Feb 10, 2024

In this pull request, I have added a --sort-by-stats flag to the html-report
command. This flag provides an option for users to order the files in the index
page of the report by their coverage statistics in ascending order.

I have also ensured that this new flag works in conjunction with the existing
--tree option : when both --sort-by-stats and --tree flags are used, the
directories, as well as the files within each directory, are sorted by coverage
statistics.

This addition is intended to offer a different perspective for developers who
are working on improving coverage in existing codebases. By presenting files
with lower coverage at the top, this option could potentially assist in
prioritizing areas that may benefit from additional testing.

Note on Code Formatting

I encountered some difficulties to fmt the code due to issues finding a
compatible combination of dependencies with opam. Despite trying several OCaml
switches ranging from 4.05 to 5.1, I was unsuccessful. The ocamlformat.0.16.0
version seems to be outdated. Any assistance in resolving this issue would be
greatly appreciated!

Looking forward to your feedback!

@aantron aantron merged commit e302656 into aantron:master Feb 12, 2024
8 of 16 checks passed
@aantron
Copy link
Owner

aantron commented Feb 12, 2024

Thank you!

Bisect_ppx doesn't use dune fmt for the source code. It only uses ocamlformat for sanitizing test output.

@mbarbin
Copy link
Contributor Author

mbarbin commented Feb 13, 2024

Thank you for merging, and for the style changes. Much appreciated 😃

@mbarbin mbarbin deleted the html-report.sort-by-stats branch February 13, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants