Remove tempto-logging-log4j module

This is module is not used anyway. Additionally it is difficult to
maintain because it is accessing test context during test initialization
(and so during test context initialization).

README.md

@@ -46,36 +46,6 @@ For example, typical configuration is:
 
 Tempto uses SLF4J for logging.
 
-### Log file per test
-
-If you are using log4j as your SLF4J backend we provide an appender which allows logging output of
-each test and suite fulfillment process to separate files. To use that configure LOG4J appender as below:
-
-```
-log4j.rootLogger=INFO, TEST_FRAMEWORK_LOGGING_APPENDER
-log4j.appender.TEST_FRAMEWORK_LOGGING_APPENDER=io.prestosql.tempto.logging.TestFrameworkLoggingAppender
-log4j.category.io.prestosql.tempto=DEBUG
-```
-
-With this appender for each test suite run new logs directory is created within /tmp/tempto_logs. Name of directory
-corresponds to time when Tempto is run (e.g. /tmp/tempto_logs/2015-04-22_15-23-09).
-Log messages coming from different tests are logged to separate files.
-
-Example contents of log directory:
-```
-io.prestosql.tests.hive.TestAllDatatypesFromHiveConnector.testSelectAllDatatypesOrc_2019-02-07_15-23-09
-io.prestosql.tests.hive.TestAllDatatypesFromHiveConnector.testSelectAllDatatypesParquetFile_2019-02-07_15-23-09
-io.prestosql.tests.hive.TestAllDatatypesFromHiveConnector.testSelectAllDatatypesRcfile_2019-02-07_15-23-09
-io.prestosql.tests.hive.TestAllDatatypesFromHiveConnector.testSelectAllDatatypesTextFile_2019-02-07_15-23-09
-io.prestosql.tests.hive.TestAllDatatypesFromHiveConnector.testSelectBinaryColumnTextFile_2019-02-07_15-23-09
-io.prestosql.tests.hive.TestAllDatatypesFromHiveConnector.testSelectVarcharColumnForOrc_2019-02-07_15-23-09
-SUITE_2015-04-22_15-23-09
-```
-
-If you want to override root location of logs you can use io.prestosql.tempto.root.logs.dir
-```
-java -Dio.prestosql.tempto.root.logs.dir=/my/root/logs/dir ...
-```
 
 ### logging test id
 

build.gradle

@@ -105,7 +105,6 @@ ext.libraries = [
 ]
 
 ext.tempto_core = project(':tempto-core')
-ext.tempto_logging_log4j = project(':tempto-logging-log4j')
 ext.tempto_examples = project(':tempto-examples')
 ext.tempto_runner = project(':tempto-runner')
 ext.tempto_ldap = project(':tempto-ldap')

tempto-core/src/test/resources/log4j.properties

@@ -13,7 +13,6 @@
 #
 # Set root logger to INFO and add a custom appender.
 log4j.rootLogger=TRACE, TEST_FRAMEWORK_LOGGING_APPENDER, CONSOLE
-log4j.appender.TEST_FRAMEWORK_LOGGING_APPENDER=io.prestosql.tempto.logging.TestFrameworkLoggingAppender
 
 log4j.appender.CONSOLE=org.apache.log4j.ConsoleAppender
 log4j.appender.CONSOLE.Target=System.out

tempto-examples/build.gradle

@@ -26,7 +26,6 @@ dependencies {
     compile libraries.slf4j_api
     compile libraries.junit
 
-    runtime tempto_logging_log4j
     runtime libraries.slf4j_log4j
     runtime libraries.postgresql_jdbc
     runtime libraries.presto_jdbc

tempto-examples/src/main/resources/log4j.properties

@@ -12,9 +12,6 @@
 # limitations under the License.
 #
 log4j.rootLogger=INFO, TEST_FRAMEWORK_LOGGING_APPENDER, CONSOLE
-log4j.appender.TEST_FRAMEWORK_LOGGING_APPENDER=io.prestosql.tempto.logging.TestFrameworkLoggingAppender
-log4j.appender.TEST_FRAMEWORK_LOGGING_APPENDER.layout=org.apache.log4j.PatternLayout
-log4j.appender.TEST_FRAMEWORK_LOGGING_APPENDER.layout.conversionPattern=[%d{yyyy-MM-dd HH:mm:ss}] [%p] %c{10}: %m%n
 log4j.appender.CONSOLE=org.apache.log4j.ConsoleAppender
 log4j.appender.CONSOLE.Target=System.out
 log4j.appender.CONSOLE.layout=org.apache.log4j.PatternLayout