Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added onFinished callback to TextLiquidFill #262

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ertgrulll
Copy link

Added onFinished callback to TextLiquidFill, readme and example updated according to change.

@SirusCodes
Copy link
Collaborator

@aagarwal1012 I guess it will be a great addition to all the animation not only TextLiquidFill, so it would be great if it would be included in AnimatedTextKit class so every animation will get this.
I just wanted to know that if there is any way we already support this?

@ertgrulll
Copy link
Author

ertgrulll commented Jul 4, 2021

AnimatedTextKit already has onFinished that triggering on children animations end. But TextLiquidFill is not using as AnimatedTextKit child. I am routing user to another screen on this animation end, so I was need to listen that. I think just TextLiquidFill need this property 🙄

@codecov
Copy link

codecov bot commented Jul 4, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.44%. Comparing base (24c2592) to head (f64bfb8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
+ Coverage   95.38%   95.44%   +0.06%     
==========================================
  Files          10       10              
  Lines         455      461       +6     
==========================================
+ Hits          434      440       +6     
  Misses         21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aagarwal1012 aagarwal1012 requested a review from awhitford July 5, 2021 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants