Add the colophon block #29
Conversation
block/block.json
Outdated
| "fontSize": true, | ||
| "lineHeight": true, | ||
| "__experimentalFontFamily": true, | ||
| "__experimentalFontStyle": true, | ||
| "__experimentalFontWeight": true, | ||
| "__experimentalLetterSpacing": true, | ||
| "__experimentalTextTransform": true, | ||
| "__experimentalDefaultControls": { | ||
| "fontSize": true | ||
| } |
There was a problem hiding this comment.
I assume these are all managed via the block attributes, which is why we don't have styles implementing them. 👍
There was a problem hiding this comment.
I believe we should keep them because it helps user to customize the styling without having to write any CSS. So, should we keep or remove them?
| "editorStyle": "file:./index.css", | ||
| "style": "file:./style-index.css", | ||
| "render": "file:./render.php" | ||
| } |
There was a problem hiding this comment.
I know block context can be used to set a block where it can only be used in a post context or the like --
https://developer.wordpress.org/block-editor/reference-guides/block-api/block-context/
Is there an option we can set so that the block is only usable in a FSE / page template context, so we're not cluttering up the block options when someone's writing a post?
There was a problem hiding this comment.
Blocks meant for use in FSE themes are called Theme Blocks, and I think this would be the way to do it:
There was a problem hiding this comment.
Currently, even if using theme as the category for the theme block. It is still visible in the post editor. The only option I can think of now is to remove the block programatically on the post editor. Should we go that route?
| @@ -0,0 +1,3 @@ | |||
| <div <?php echo wp_kses_data( get_block_wrapper_attributes() ); ?>> | |||
There was a problem hiding this comment.
I'm not sure this wp_kses_data() call is necessary here -- as it is designed to be sanitizing not escaping, (so focused on content not context), and doesn't seem to be used by the Gutenberg team when doing similar tasks:
There was a problem hiding this comment.
I use it because it is there in the example for dynamic block.
Changes proposed in this Pull Request
Testing instructions
Colophonblock.Mentions #8